Skip to content

GDPR & Google Analytics.#40

Merged
BorjaOuterelo merged 6 commits into
masterfrom
feature/ganalytics
Jun 6, 2019
Merged

GDPR & Google Analytics.#40
BorjaOuterelo merged 6 commits into
masterfrom
feature/ganalytics

Conversation

@BorjaOuterelo
Copy link
Copy Markdown
Contributor

Add GDPR cookies handling.
Adds Google Analytics.
Change Arne twitter account. (Changed user name?).
Use -nocookie version of youtube (GDPR).

norro
norro previously approved these changes May 21, 2019
imuguruza
imuguruza previously approved these changes May 21, 2019
Copy link
Copy Markdown
Contributor

@ralph-lange ralph-lange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See separate mail with background information to GDPR requirements.

@BorjaOuterelo
Copy link
Copy Markdown
Contributor Author

@ralph-lange I got your email. I will update this PR with that information. Thanks.

@BorjaOuterelo BorjaOuterelo dismissed stale reviews from imuguruza and norro via 8508c65 June 5, 2019 14:20
@BorjaOuterelo BorjaOuterelo requested review from imuguruza, norro and ralph-lange and removed request for imuguruza June 5, 2019 14:33
Copy link
Copy Markdown
Contributor

@ralph-lange ralph-lange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IANAL. Looks good to me.

@BorjaOuterelo BorjaOuterelo merged commit 08efb2b into master Jun 6, 2019
@BorjaOuterelo BorjaOuterelo deleted the feature/ganalytics branch June 6, 2019 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants