Adding Edge Impulse + micro-ROS demo#389
Conversation
ralph-lange
left a comment
There was a problem hiding this comment.
Thank you very much for contributing this demo/tutorial. The description is very well done and concise. With two somewhat longer sentences, readability can be increased by a comma, I think. But I am not a native speaker.
Also, you may omit the _demo' in the folder name since the parent folder is already named demos. (I know, all other folders have this unnecessary _demo`.)
Co-authored-by: Ralph Lange <ralph-lange@users.noreply.github.com>
Co-authored-by: Ralph Lange <ralph-lange@users.noreply.github.com>
|
I changed the folder name as requested :) Let me know if there is anything else. Thanks. |
ralph-lange
left a comment
There was a problem hiding this comment.
Perfect. Thanks again very much!
|
I realized I hadn't changed the name of the folder within the header as well, so I did that now. I don't know if that is the reason why the build failed..? Edit: Sorry, now I see that you merged the most recent commit. My mistake. |
|
The build failed because of few broken links in other pages of the website - not in your page. |
|
@ralph-lange sorry to be a nuisance - but shall I also update |
Hi @ralph-lange ,
Thanks for the invitation to add this demo page. I hope I formatted everything correctly. I will be in touch when I add more examples / additional board support to coordinate with you whether to update this demo page.