Implemented Hash table and spec.#74
Merged
Merged
Conversation
This was referenced Jul 13, 2015
Closed
Owner
There was a problem hiding this comment.
I'd use val !== undefined && val !== null && typeof val.valueOf() === 'number' here, otherwise I'd cast val to string using '' + val, which should work in case val is undefined or null.
Owner
|
Looks awesome, great job! I'll merge it the way it is. If you agree about the note above you can push the change in master, if you think it might create any issues we can discuss them here. |
mgechev
added a commit
that referenced
this pull request
Jul 13, 2015
Implemented Hash table and spec.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creating a PR for this so you can check it out @mgechev before we bring it in. I started off with #68 as a base, and did quite a bit of modification.
I'm going to add documentation also before we merge it in.
The main thing to note is an added optional (not to be used by anything other than test/spec) parameter, hashCode, to get(), put(), remove(). This is used to simulate collisions. I did this since finding keys that are different, but generate the same hash, using the javascript implementation of java's 32bitint hash function (that I brought over from #68) would have been a pain.