Adding metrics endpoint for prometheus scraping#28
Closed
wileyj wants to merge 1 commit into
Closed
Conversation
Owner
|
Apologies for late reply. Sorry and as you guessed, this is out of scope or intention of this tool, and it adds another layer of maintenance/overhead for me. |
Author
|
no problem at all, thanks for taking a look |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a metrics endpoint for the app on port
9153using promster.Why? When working with prometheus, it's sometimes easier to have a small app you can scrape from where the data is consistent.
This PR adds a very basic prometheus server to the application, exposing metrics server on port
9153that can be requested:curl -s localhost:9153.It may be out of scope from the original intent of this repo, but I've found these changes useful and can imagine others might as well.
Example output: