Fixes #2253 - increase server keep alive timeout#2256
Merged
codyebberson merged 1 commit intomainfrom Jun 19, 2023
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
codyebberson
commented
Jun 19, 2023
| return { rows: [{ version: 1000000 }] }; | ||
| } | ||
| if (sql === 'SELECT "User"."id", "User"."content" FROM "User" WHERE "deleted"=$1 LIMIT 1') { | ||
| if (sql === 'SELECT "User"."id", "User"."content" FROM "User" WHERE "User"."deleted"=$1 LIMIT 2') { |
Member
Author
There was a problem hiding this comment.
This is the query to check "is the database seeded". The existing query was out of date, so the test would unnecessarily re-seed the database. By fixing this line, the test went from 52 seconds to 3 seconds.
reshmakh
approved these changes
Jun 19, 2023
|
Kudos, SonarCloud Quality Gate passed! |
tonylee80
reviewed
Jun 19, 2023
| const app = await initApp(express(), config); | ||
| app.listen(config.port); | ||
| const server = app.listen(config.port); | ||
| server.keepAliveTimeout = config.keepAliveTimeout ?? 90000; |
Contributor
There was a problem hiding this comment.
Not sure if this applies to us, do we need to have set servers.headersTimeout to be greater than server.keepAliveTimeout as per
nodejs/node#27363 (comment) and
https://shuheikagawa.com/blog/2019/04/25/keep-alive-timeout/?
server.keepAliveTimeout = 61 * 1000;
server.headersTimeout = 65 * 1000; // This should be bigger than `keepAliveTimeout + your server's expected response time`
Member
Author
There was a problem hiding this comment.
Great question. My interpretation of the discussion in that ticket is that the headersTimeout thing was fixed. I'll double check
Member
Author
There was a problem hiding this comment.
yokomotod commented on Jun 21, 2020
Since nodejs/node#32329 was merged, now I don't need to set headersTimeout bigger than keepAliveTimeout, right ?
@yokomotod if you're asking for v12, v12.19.0 contains the fix
tonylee80
approved these changes
Jun 19, 2023
Closed
codyebberson
added a commit
that referenced
this pull request
Jun 22, 2023
Require prefer: respond-async for super admin tools (#2276) Suppress console errors on cancelled fetch (#2278) Fixes #2126 - Moved access helpers to core (#2272) Only deploy image built with Node.js 18 (#2275) Remove projectId update from migration (#2274) Add Non-nullable fields for graphql (#2271) Add projectId columns to all resource tables (#2270) Adding additional blog content and updating the number of items blog … (#2258) Update super-admin-guide.md (#2267) Dependency upgrades (#2268) Fixes #2176: Target Directory Options for Bulk CLI commands (#2265) Fixes #2261 - Use Data Absent Reason extension for unsupported BCDA r… (#2264) Update Turbo (#2262) Validate super admin client assigned IDs (#2263) Updated discord link (#2260) Upload Introspection Query (#2214) Unify the schema loading flows (#2257) Fixes #2253 - increase server keep alive timeout (#2256) Fixes #2254 - handle punctuation in ValueSet expand (#2255) Fixes #2225 - Added AWS Athena guide (#2252) FhirPathCriteria Docs (#2251) Add new validator in log-only mode (#2171) Fixes #2235 - Add docs for maxJsonSize (#2247) Fixes #2218 - Set vercel install and build commands (#2248) Updating contributing guides, includes updated images (#2242)
codyebberson
added a commit
that referenced
this pull request
Jun 22, 2023
Require prefer: respond-async for super admin tools (#2276) Suppress console errors on cancelled fetch (#2278) Fixes #2126 - Moved access helpers to core (#2272) Only deploy image built with Node.js 18 (#2275) Remove projectId update from migration (#2274) Add Non-nullable fields for graphql (#2271) Add projectId columns to all resource tables (#2270) Adding additional blog content and updating the number of items blog … (#2258) Update super-admin-guide.md (#2267) Dependency upgrades (#2268) Fixes #2176: Target Directory Options for Bulk CLI commands (#2265) Fixes #2261 - Use Data Absent Reason extension for unsupported BCDA r… (#2264) Update Turbo (#2262) Validate super admin client assigned IDs (#2263) Updated discord link (#2260) Upload Introspection Query (#2214) Unify the schema loading flows (#2257) Fixes #2253 - increase server keep alive timeout (#2256) Fixes #2254 - handle punctuation in ValueSet expand (#2255) Fixes #2225 - Added AWS Athena guide (#2252) FhirPathCriteria Docs (#2251) Add new validator in log-only mode (#2171) Fixes #2235 - Add docs for maxJsonSize (#2247) Fixes #2218 - Set vercel install and build commands (#2248) Updating contributing guides, includes updated images (#2242)
Merged
codyebberson
added a commit
that referenced
this pull request
Jun 23, 2023
Require prefer: respond-async for super admin tools (#2276) Suppress console errors on cancelled fetch (#2278) Fixes #2126 - Moved access helpers to core (#2272) Only deploy image built with Node.js 18 (#2275) Remove projectId update from migration (#2274) Add Non-nullable fields for graphql (#2271) Add projectId columns to all resource tables (#2270) Adding additional blog content and updating the number of items blog … (#2258) Update super-admin-guide.md (#2267) Dependency upgrades (#2268) Fixes #2176: Target Directory Options for Bulk CLI commands (#2265) Fixes #2261 - Use Data Absent Reason extension for unsupported BCDA r… (#2264) Update Turbo (#2262) Validate super admin client assigned IDs (#2263) Updated discord link (#2260) Upload Introspection Query (#2214) Unify the schema loading flows (#2257) Fixes #2253 - increase server keep alive timeout (#2256) Fixes #2254 - handle punctuation in ValueSet expand (#2255) Fixes #2225 - Added AWS Athena guide (#2252) FhirPathCriteria Docs (#2251) Add new validator in log-only mode (#2171) Fixes #2235 - Add docs for maxJsonSize (#2247) Fixes #2218 - Set vercel install and build commands (#2248) Updating contributing guides, includes updated images (#2242)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #2253
AWS ALB idle timeout is 60 seconds. Node.js server timeout must be greater than that to avoid 502 Bad Gateway errors. This PR increases the default keep alive timeout to 90 seconds.