Add AbortController.abort() parameter reason#25068
Merged
Conversation
AbortController.abort() reasonAbortController.abort() parameter reason
caugner
approved these changes
Nov 15, 2024
Contributor
caugner
left a comment
There was a problem hiding this comment.
LGTM, verified the referenced sources for Chrome, Deno, Firefox, Node.js, and Safari.
This was referenced Nov 15, 2024
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
data were taken from
AbortSignal.abort()static methodreasonparameter, and in fact it is a part of this featurechrome data confirmed by chromium/chromium@155b235 and https://issues.chromium.org/issues/40202936 (#16956)
deno data confirmed by https://docs.deno.com/api/web/~/AbortController.abort and denoland/deno#12697 (#13380)
firefox data confirmed by mozilla/gecko-dev@712c0d5 and https://bugzilla.mozilla.org/show_bug.cgi?id=1737771 (#14418)
nodejs data confirmed by https://nodejs.org/docs/latest/api/globals.html#abortcontrollerabortreason and nodejs/node#40807 (#17418)
safari data confirmed by WebKit/WebKit@d354a8d and https://bugs.webkit.org/show_bug.cgi?id=232299 (#16956)
Test results and supporting details
Related issues
Fixes #24899