Disable the message composer if we don't have permission to post to the room#247
Disable the message composer if we don't have permission to post to the room#247
Conversation
…ol wrapper so we can make it the right width
|
Looks ok, but it would make me much happier if you factored out a separate component (maybe the |
|
Yeah, this would make a lot of sense because all the command history stuff could be factored out too. I wouldn't want to mix that in with this PR though. |
|
Sure. So first factor it out, then make the change? I think this looks fragile at the moment - it's very hard to be sure that you've got enough null guards in there, and it's going to be very easy to break it in future. If you want to go ahead and merge it because time is short, I won't throw my toys out of the pram; but the only time the refactor is going to happen is when you need to do some work on the code in question. (In other words: there is never a good time to do refactoring.) |
|
I'm going to take this off dave's hands and do the refactor first. |
Fixes element-hq/element-web#386
Requires matrix-org/matrix-js-sdk#118 and element-hq/element-web#1249