Allow making non-native site links server-absolute#26
Allow making non-native site links server-absolute#26tacaswell merged 2 commits intomatplotlib:mainfrom
Conversation
|
The top level won't resolve for the other websites that use the theme, though. Ie mpl-third-party etc? |
|
Locally maybe, but not once on the site. They are all on the same server. Maybe we need an option as in matplotlib/mpl-brochure-site#41? |
c780b73 to
251a6f8
Compare
|
OK, I modified the |
|
Alternatively, perhaps this should be |
| "native_site": False | ||
| # Determines the type of links produced in the navigation header: | ||
| # - absolute: Links point to the URL https://matplotlib.org/... | ||
| # - relative: Links point to top-level of the server /... |
There was a problem hiding this comment.
Discussed with Elliott on a a call, suggested this be rename to "server_stable" or something similar..
... instead of globally absolute with an explicit server name. This allows the docs to be served from a different server (e.g., on localhost), without links leaking out to the real matplotlib.org.
Due to the merging of matplotlib/mpl-sphinx-theme#26
Due to the merging of matplotlib/mpl-sphinx-theme#26
... instead of globally absolute with an explicit server name. This allows the docs to be served from a different server (e.g., on localhost), without links leaking out to the real matplotlib.org.