Skip to content

ENH/MacOS Allow shift modifiers to key events#9836

Merged
dopplershift merged 1 commit intomatplotlib:masterfrom
jklymak:mac-allow-shift
Nov 28, 2017
Merged

ENH/MacOS Allow shift modifiers to key events#9836
dopplershift merged 1 commit intomatplotlib:masterfrom
jklymak:mac-allow-shift

Conversation

@jklymak
Copy link
Copy Markdown
Member

@jklymak jklymak commented Nov 22, 2017

PR Summary

#9835 points out that "shift-left" etc not allowed for macOS. This PR fixes that by allowing a
shift modifier if the other key is a special key...

To test, use the script by the OP:

import matplotlib.pyplot as plt
fig = plt.figure()

def on_key(event):
    print('you pressed', event.key, event.xdata, event.ydata)

fig.canvas.mpl_connect('key_press_event', on_key)
plt.show()

PR Checklist

  • [N/A] Has Pytest style unit tests
  • [N/A] Code is PEP 8 compliant

@jklymak jklymak mentioned this pull request Nov 23, 2017
Closed
@cbrnr cbrnr mentioned this pull request Nov 23, 2017
Merged
@cbrnr
Copy link
Copy Markdown
Contributor

cbrnr commented Nov 23, 2017 •
edited
Loading

I don't have a dev env set up yet, but this looks super nice! Thanks a lot!

@cbrnr
Copy link
Copy Markdown
Contributor

cbrnr commented Nov 23, 2017

I can't test this because my figs do not get focus - every key I type goes directly to the terminal... This happens only when using conda (it works with Python installed via Homebrew, I'll try to setup a virtualenv there).

@cbrnr
Copy link
Copy Markdown
Contributor

cbrnr commented Nov 23, 2017

cf #9839

@cbrnr
Copy link
Copy Markdown
Contributor

cbrnr commented Nov 23, 2017

@jklymak do I need to do anything in addition to python -mpip install .? In my example, shift combinations are still not detected.

@tacaswell tacaswell added this to the v2.2 milestone Nov 23, 2017
@dstansby
Copy link
Copy Markdown
Member

dstansby commented Nov 27, 2017

That should work - what does print(matplotlib.__version__) output?

@cbrnr
Copy link
Copy Markdown
Contributor

cbrnr commented Nov 28, 2017

'2.1.0'

but

conda list matplotlib:

matplotlib                2.0.2+5783.g6284e1298           <pip>

@dstansby
Copy link
Copy Markdown
Member

dstansby commented Nov 28, 2017

That's odd... maybe try conda uninstall matplotlib and pip uninstall matplotlib and trying installing from source again.

@cbrnr
Copy link
Copy Markdown
Contributor

cbrnr commented Nov 28, 2017

For some reason, I was using pythonw from my main Anaconda env even though I activated another env for building your matplotlib version. Installing Python.app explicitly in the env solved this issue.

And yes, your fix is working! Thanks a lot! Now if only Anaconda made the framework thing the default with their packages it would also work on macOS out of the box (but this is not related to matplotlib).

@dopplershift dopplershift merged commit 96ac97c into matplotlib:master Nov 28, 2017
@QuLogic QuLogic modified the milestones: needs sorting, v2.2.0 Feb 12, 2018
@jklymak jklymak deleted the mac-allow-shift branch March 5, 2019 16:09
@Pixadus Pixadus mentioned this pull request Jun 22, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dopplershift dopplershift dopplershift approved these changes

@dstansby dstansby dstansby approved these changes

Assignees

No one assigned

Labels

GUI: MacOSX

Projects

None yet

Milestone

v2.2.0

Development

Successfully merging this pull request may close these issues.

6 participants

@jklymak @cbrnr @dstansby @dopplershift @tacaswell @QuLogic