Skip to content

Bug Fix: DraggableBase not to move unselected object #7894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fukatani wants to merge 1 commit into from
Closed

Bug Fix: DraggableBase not to move unselected object #7894

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion lib/matplotlib/offsetbox.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1650,6 +1650,7 @@ def finalize_offset(self):
def __init__(self, ref_artist, use_blit=False):
self.ref_artist = ref_artist
self.got_artist = False
self.got_other_artist = False

self.canvas = self.ref_artist.figure.canvas
self._use_blit = use_blit and self.canvas.supports_blit
Expand Down Expand Up @@ -1677,7 +1678,9 @@ def on_motion_blit(self, evt):
self.canvas.blit(self.ref_artist.figure.bbox)

def on_pick(self, evt):
if evt.artist == self.ref_artist:
if self.got_other_artist:
return
if self.got_artist or evt.artist == self.ref_artist:

self.mouse_x = evt.mouseevent.x
self.mouse_y = evt.mouseevent.y
Expand All @@ -1696,8 +1699,11 @@ def on_pick(self, evt):
self._c1 = self.canvas.mpl_connect('motion_notify_event',
self.on_motion)
self.save_offset()
else:
self.got_other_artist = True

def on_release(self, event):
self.got_other_artist = False
if self.got_artist:
self.finalize_offset()
self.got_artist = False
Expand Down