Skip to content

ENH: _StringFuncParser to get numerical functions callables from strings #7464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
efiring merged 11 commits into from
Dec 15, 2016
Merged

ENH: _StringFuncParser to get numerical functions callables from strings #7464

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
0ad3710
First commit
alvarosg Nov 15, 2016
509ed9f
Creation of class _FuncInfo
alvarosg Nov 15, 2016
bb042f6
Added parameter check, and other feedback from the PR
Nov 16, 2016
4fa16f3
Removed np.cbrt for compatibility with older numpy versions
alvarosg Nov 16, 2016
c5770fd
Corrections from @efiring
alvarosg Dec 13, 2016
69f2a04
Solved compatibility error with python 3+
alvarosg Dec 13, 2016
94a1af0
Feedback from @story645
alvarosg Dec 14, 2016
331d5d3
Tiny change missing @story645
alvarosg Dec 14, 2016
a45f217
Changed exception message
alvarosg Dec 14, 2016
3bd901e
Fixed typo
alvarosg Dec 14, 2016
c143e75
Implemented feedback from @QuLogic
alvarosg Dec 15, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Solved compatibility error with python 3+
  • Loading branch information
@alvarosg
alvarosg committed Dec 13, 2016
commit 69f2a0440b7aeed55d4999e36f4e8b80533130f5
2 changes: 1 addition & 1 deletion lib/matplotlib/cbook.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2851,7 +2851,7 @@ def _get_key_params(self):

try:
func = self._funcs[str_func]
except ValueError, KeyError:
except (ValueError, KeyError):
raise ValueError("%s: invalid string. The only strings "
Copy link
Copy Markdown
Member

@story645 story645 Dec 14, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"%s is an invalid string.

"recognized as functions are %s." %
(str_func, list(self._funcs)))
Expand Down