Skip to content

PEP8: adjust some long lines#3949

Merged
tacaswell merged 2 commits into
matplotlib:masterfrom
argriffing:pep8-long-lines
Feb 19, 2015
Merged

PEP8: adjust some long lines#3949
tacaswell merged 2 commits into
matplotlib:masterfrom
argriffing:pep8-long-lines

Conversation

@argriffing
Copy link
Copy Markdown

The # noqa is supposed to pacify some pep8 checkers. I left the long urls in docstrings alone.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, very clever SO, very clever....

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need for a trailing slash?

@tacaswell
Copy link
Copy Markdown
Member

New(er) versions of pep8 should ignore url lines without the need for #noqa

@tacaswell
Copy link
Copy Markdown
Member

See discussion at PyCQA/pycodestyle#326 which loops back to #3507 (comment)

@tacaswell tacaswell added this to the unassigned milestone Dec 29, 2014
Comment thread lib/matplotlib/artist.py Outdated
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, there was a discussion yesterday about this very link, and it is rotted as-is. There is a more correct URL to use here: https://mail.python.org/pipermail/python-list/2004-October/255696.html

@tacaswell
Copy link
Copy Markdown
Member

Can you remove the noqa markers?

@argriffing
Copy link
Copy Markdown
Author

@tacaswell OK, removed them.

tacaswell added a commit that referenced this pull request Feb 19, 2015
@tacaswell tacaswell merged commit 1fe5b9c into matplotlib:master Feb 19, 2015
@tacaswell
Copy link
Copy Markdown
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants