Fixes Agg/Cairo antialiased rendering of contourf/pcolor/pcolormesh by using a blend group - #32256
Fixes Agg/Cairo antialiased rendering of contourf/pcolor/pcolormesh by using a blend group#32256ayshih wants to merge 2 commits into
Conversation
71f2be2 to
7741f0b
Compare
7741f0b to
3c1da25
Compare
|
Would it make sense/work to apply this to all Collections? |
|
Can you explain what exactly is happening and why it's fixed via a plus blend mode? I think that may have gotten buried in the other PR. My first reaction was "this makes basic sense, but I need to look up the formula for Plus again." |
iccir
left a comment
There was a problem hiding this comment.
Maybe add a comment about why "plus" was chosen, but there are also existing comments in the source base about this + intermediate buffers.
|
The matplotlib/lib/matplotlib/axes/_axes.py Lines 6697 to 6699 in 17552e2 Those artificial lines are now gone, so this explanation no longer makes sense. Should we change the default? The default for |
I'm +1 on "default to the more-correct-looking option", unless there are other concerns. |
PR summary
This PR fixes Agg/Cairo antialiased rendering of contourf/pcolor/pcolormesh by using a blend group (see #31162, where these fixes were separated out of). In the examples below, look at the right-most panel and see how the faint lines between antialiased patches are fixed by this PR. (The other panels are for showing why it is desirable to turn on antialiasing when alpha < 1.)
Since these fixes require #31162, this PR cannot be backported to 3.11.x.
contourf
Before this PR
After this PR
pcolor/pcolormesh
Before this PR
After this PR
AI Disclosure
No AI was used
PR quality check