BLD: Force all internal extension symbols to be hidden - #32209
Open
QuLogic wants to merge 1 commit into
Open
Conversation
Even though Meson defaults to hidden visibility, our bundled libraries like FreeType may themselves export their own symbols individually. So force all symbols other than the Python module initialization function to be hidden with a linker version script. By making symbols like `FT_Init_Freetype` local, it ensures that they cannot be resolved by other global versions, such as a system copy loaded beforehand. It also allows the linker to discard more sections for unused code, saving us approximately 6.6% in shared library space.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
Even though Meson defaults to hidden visibility, our bundled libraries like FreeType may themselves export their own symbols individually. So force all symbols other than the Python module initialization function to be hidden with a linker version script.
By making symbols like
FT_Init_Freetypelocal, it ensures that they cannot be resolved by other global versions, such as a system copy loaded beforehand. It also allows the linker to discard more sections for unused code, saving us approximately 6.6% in shared library space.Fixes #32208
AI Disclosure
None
PR quality check