Implement Figure-level overlay architecture with two-pass drawing - #32199
Open
Vikash-Kumar-23 wants to merge 3 commits into
Open
Implement Figure-level overlay architecture with two-pass drawing#32199Vikash-Kumar-23 wants to merge 3 commits into
Vikash-Kumar-23 wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
This PR introduces a foundational Figure-level overlay architecture to
figure.py. It implements a two-pass drawing system, allowing developers to cleanly segregate base plot artists from overlay artists.Key Changes:
_overlay_childrentoFigureBase. Figure elements are now routed to either_children(base layer) or_overlay_children(overlay layer).Figure.draw()to execute in two distinct passes:_draw_base_layer(): Renders the figure patch (background) and all artists in_children._draw_overlay_layer(): Renders all artists in_overlay_children._overlay=Falsekeyword-only argument to key artist insertion methods (add_artist,text,legend,figimage)._overlaykeyword through thesuptitle,supxlabel, andsupylabelfamily (via_suplabels) down to the underlyingtextcalls.Addresses #30515
AI Disclosure
AI tools were used to assist in drafting text and suggesting validation scenarios.
All code changes, final implementation decisions, and verification were done manually.
PR quality check