Make the frame size of animation writers be the canvas size rather than the figure size - #32194
Draft
ayshih wants to merge 1 commit into
Draft
Make the frame size of animation writers be the canvas size rather than the figure size#32194ayshih wants to merge 1 commit into
ayshih wants to merge 1 commit into
Conversation
QuLogic
reviewed
Aug 10, 2026
| ho /= self.dpi | ||
| if self.codec == 'h264': | ||
| wo, ho = self.fig.get_size_inches() | ||
| w, h = adjusted_figsize(wo, ho, self.dpi, 2) |
Member
There was a problem hiding this comment.
What about the calculation in adjusted_figsize?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
As reported in #32186, the change in #32038 to have appropriately rounded canvas sizes made the necessary updates to the backends, but missed that
matplotlib.animationalso needed to be updated. This PR updatesmatplotlib.animationto use the canvas size rather than the figure size for the frame size.Closes #32186
AI Disclosure
No AI was used
PR quality check