fix subfigures wspace/hspace=None using rc defaults instead of zero#32098
Open
sanrishi wants to merge 2 commits into
Open
fix subfigures wspace/hspace=None using rc defaults instead of zero#32098sanrishi wants to merge 2 commits into
sanrishi wants to merge 2 commits into
Conversation
Contributor
Author
|
Noticed the existing test_subfigures_wspace_hspace covers the case where both are set, but there wasn't one for the partial None case. Added test_subfigures_partial_spacing to cover that. Let me know if the approach looks right or if you'd prefer a different fix location. |
sanrishi
force-pushed
the
fix/subfigure-none-spacing
branch
from
July 22, 2026 21:05
d2caede to
01046b7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When subfigures() is called without a layout engine and only one of wspace/hspace is specified (e.g. wspace=0.2, hspace=None), the None value gets passed through GridSpec to SubplotParams which leaves the rcParam default (0.2) in place. This causes an unintended gap on the unspecified axis.
The docs say None should mean zero when no layout engine is active, so coerce missing values to 0.0 before constructing the GridSpec.
Fixes #32076