Fix occasional misalignment in reported mouse position#32038
Draft
ayshih wants to merge 1 commit into
Draft
Conversation
Member
|
I’m wondering whether we should make an explicit concept out of this. While figure size can be any float, the canvas - at least for raster backends - must be integer. So it seems we should rather take the size from the canvas? Possibly https://matplotlib.org/stable/api/backend_bases_api.html#matplotlib.backend_bases.FigureCanvasBase.get_width_height |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
Due to floating-point precision, a figure may self-report a height that is not exactly an integer, and the consequence is a bug for GUI backends where the reported Y position of the mouse may be off by a pixel. This PR fixes the bug in various backends by immediately rounding the figure height rather than letting it be truncated later.
Fixes #27570
AI Disclosure
No AI was used
PR checklist