Skip to content

ENH/MAINT: Improve legend handling in Qt figure options dialog #32015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jhkr1 wants to merge 1 commit into
base: main
Choose a base branch
from
+20 −1
Open

ENH/MAINT: Improve legend handling in Qt figure options dialog #32015

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 20 additions & 1 deletion lib/matplotlib/backends/qt_editor/figureoptions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ def convert_limits(lim, converter):
)
for name, axis in axis_map.items()
]),
('Show legend', axes.legend_ is not None and axes.legend_.get_visible()),
('(Re-)Generate automatic legend', False),
]

Expand Down Expand Up @@ -196,6 +197,7 @@ def apply_callback(data):
title = general.pop(0)
axes.title.set_text(title)
generate_legend = general.pop()
show_legend = general.pop()

for i, (name, axis) in enumerate(axis_map.items()):
axis_min = general[4*i]
Expand Down Expand Up @@ -248,14 +250,31 @@ def apply_callback(data):
if generate_legend:
draggable = None
ncols = 1
kwargs = {}
if axes.legend_ is not None:
old_legend = axes.get_legend()
draggable = old_legend._draggable is not None
ncols = old_legend._ncols
new_legend = axes.legend(ncols=ncols)
kwargs = {
'loc': old_legend._loc_real,
'title': old_legend.get_title().get_text(),
'frameon': old_legend.get_frame_on(),
'shadow': old_legend.shadow,
}
# Clone frame properties if the frame exists
frame = old_legend.get_frame()
if frame is not None:
kwargs['edgecolor'] = frame.get_edgecolor()
kwargs['facecolor'] = frame.get_facecolor()
kwargs['framealpha'] = frame.get_alpha()

new_legend = axes.legend(ncols=ncols, **kwargs)
if new_legend:
new_legend.set_draggable(draggable)

if axes.legend_ is not None:
axes.legend_.set_visible(show_legend)

# Redraw
figure = axes.get_figure()
figure.canvas.draw()
Expand Down
Loading