Skip to content

MAINT: Clone more legend settings in Qt figure options #32014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jhkr1 wants to merge 2 commits into from
Closed

MAINT: Clone more legend settings in Qt figure options #32014

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d8abe1d
MAINT: Clone more legend settings in Qt figure options
jhkr1 Jul 8, 2026
9d51fcb
ENH: Add legend toggle to figure options dialog
jhkr1 Jul 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 21 additions & 1 deletion lib/matplotlib/backends/qt_editor/figureoptions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@
)
for name, axis in axis_map.items()
]),
('Show legend', axes.legend_ is not None and axes.legend_.get_visible()),
('(Re-)Generate automatic legend', False),
]

Expand Down Expand Up @@ -196,6 +197,7 @@
title = general.pop(0)
axes.title.set_text(title)
generate_legend = general.pop()
show_legend = general.pop()

for i, (name, axis) in enumerate(axis_map.items()):
axis_min = general[4*i]
Expand Down Expand Up @@ -248,14 +250,32 @@
if generate_legend:
draggable = None
ncols = 1
kwargs = {}
if axes.legend_ is not None:
old_legend = axes.get_legend()
draggable = old_legend._draggable is not None
ncols = old_legend._ncols
new_legend = axes.legend(ncols=ncols)
kwargs = {
'loc': old_legend._loc_real,
'title': old_legend.get_title().get_text(),
'frameon': old_legend.get_frame_on(),
'shadow': old_legend.shadow,
}

Check warning on line 264 in lib/matplotlib/backends/qt_editor/figureoptions.py

View workflow job for this annotation

GitHub Actions / ruff 

[rdjson] reported by reviewdog 🐶
Blank line contains whitespace

Raw Output:
message:"Blank line contains whitespace"  location:{path:"/home/runner/work/matplotlib/matplotlib/lib/matplotlib/backends/qt_editor/figureoptions.py"  range:{start:{line:264  column:1}  end:{line:264  column:17}}}  severity:WARNING  source:{name:"ruff"  url:"https://docs.astral.sh/ruff"}  code:{value:"blank-line-with-whitespace"  url:"https://docs.astral.sh/ruff/rules/blank-line-with-whitespace"}  suggestions:{range:{start:{line:264  column:1}  end:{line:264  column:17}}}
# Clone frame properties if the frame exists
frame = old_legend.get_frame()
if frame is not None:
kwargs['edgecolor'] = frame.get_edgecolor()
kwargs['facecolor'] = frame.get_facecolor()
kwargs['framealpha'] = frame.get_alpha()

Check warning on line 271 in lib/matplotlib/backends/qt_editor/figureoptions.py

View workflow job for this annotation

GitHub Actions / ruff 

[rdjson] reported by reviewdog 🐶
Blank line contains whitespace

Raw Output:
message:"Blank line contains whitespace"  location:{path:"/home/runner/work/matplotlib/matplotlib/lib/matplotlib/backends/qt_editor/figureoptions.py"  range:{start:{line:271  column:1}  end:{line:271  column:13}}}  severity:WARNING  source:{name:"ruff"  url:"https://docs.astral.sh/ruff"}  code:{value:"blank-line-with-whitespace"  url:"https://docs.astral.sh/ruff/rules/blank-line-with-whitespace"}  suggestions:{range:{start:{line:271  column:1}  end:{line:271  column:13}}}
new_legend = axes.legend(ncols=ncols, **kwargs)
if new_legend:
new_legend.set_draggable(draggable)

if axes.legend_ is not None:
axes.legend_.set_visible(show_legend)

# Redraw
figure = axes.get_figure()
figure.canvas.draw()
Expand Down
Loading