Raise a clear error when grouped_bar gets singular label/color (#30739)#32006
Raise a clear error when grouped_bar gets singular label/color (#30739)#32006Kundhan73 wants to merge 1 commit into
Conversation
|
Thank you for opening your first PR into Matplotlib! If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks. We also ask that you please finish addressing any review comments on this PR and wait for it to be merged (or closed) before opening a new one, as it can be a valuable learning experience to go through the review process. You can also join us on discourse chat for real-time discussion. For details on testing, writing docs, and our review process, please see the developer guide. We strive to be a welcoming and open project. Please follow our Code of Conduct. |
Closes #30739.
Axes.grouped_barpasses each dataset'slabelandcolortobar()itself and alsoforwards
**kwargs. If a caller passes a singularlabel=/color=(they land inkwargs),bar()receives the keyword twice and raises an opaqueTypeError: ...bar() got multiple values for keyword argument 'label'.This adds an early guard in
grouped_barthat raises a clearTypeErrorpointing theuser to the plural
labels/colorsparameters, plus a parametrized test.Open question: the reporter expected
label="dataset"to work (i.e. alias singular →plural). I went with a clear error since a single label/color is ambiguous across N
datasets and contradicts the documented plural API — happy to change to aliasing if you
prefer. No changelog entry added since
grouped_baris provisional and 3.11 isunreleased; let me know if you'd like one.