ENH: Introduce OverlayManager for Phase 1 fallback rendering#32002
Open
Vikash-Kumar-23 wants to merge 4 commits into
Open
ENH: Introduce OverlayManager for Phase 1 fallback rendering#32002Vikash-Kumar-23 wants to merge 4 commits into
Vikash-Kumar-23 wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
This PR introduces the foundational
OverlayManagertobackend_bases.py, setting up the architecture required for high-frequency interactive overlays (like cursors and crosshairs) without triggering expensive background redraws.Key Changes:
OverlayManagerto manage registered overlay artists using weak references.OverlayManagertoFigureCanvasBaseinitialization.animated=Falseon artists and routing redraws todraw_idle().test_backend_bases.pyto verify the fallback behavior, registration logic, and a future-looking test (currently markedXFAIL) for native compositing in Phase 2.Addresses #30515 .
AI Disclosure
AI tools were used to assist in drafting text and suggesting validation scenarios.
All code changes, final implementation decisions, and verification were done manually.
PR checklist