MNT: Remove not so meaningful tests for PDF draw_path_collection#32001
Open
yuzie007 wants to merge 1 commit into
Open
MNT: Remove not so meaningful tests for PDF draw_path_collection#32001yuzie007 wants to merge 1 commit into
draw_path_collection#32001yuzie007 wants to merge 1 commit into
Conversation
Member
|
I agree those tests are no-ops. Sorry as I was one of the folks who approved. However I think they do test things and likely should be image comparison tests? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
Some of the tests added in #30746 using
check_figures_equalmay be not so meaningful because they compare the axes constructed in an exactly identical way. For future maintainability, I would suggest removing them. I would like to leave the decision to the maintainers.I found the above potential issue during preparation of #32000.
AI Disclosure
Unused.
PR checklist