Skip to content

Don't require an axis in PercentFormatter with explicit decimals #31995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
QuLogic merged 1 commit into from
Jul 6, 2026
+17 −2
Merged

Don't require an axis in PercentFormatter with explicit decimals #31995

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions lib/matplotlib/tests/test_ticker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1764,6 +1764,14 @@ def test_latex(self, is_latex, usetex, expected):
with mpl.rc_context(rc={'text.usetex': usetex}):
assert fmt.format_pct(50, 100) == expected

def test_call_without_axis(self):
# With explicit decimals the axis view interval is not needed, so the
# formatter should format a value even when it is not attached to an
# axis, instead of raising an AttributeError.
with mpl.rc_context(rc={'text.usetex': False}):
assert mticker.PercentFormatter(xmax=1.0, decimals=1)(0.5) == '50.0%'
assert mticker.PercentFormatter(xmax=100, decimals=0)(50) == '50%'


def _impl_locale_comma():
try:
Expand Down
11 changes: 9 additions & 2 deletions lib/matplotlib/ticker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1638,8 +1638,15 @@ def __init__(self, xmax=100, decimals=None, symbol='%', is_latex=False):

def __call__(self, x, pos=None):
"""Format the tick as a percentage with the appropriate scaling."""
ax_min, ax_max = self.axis.get_view_interval()
display_range = abs(ax_max - ax_min)
if self.decimals is None:
# The display range of the axis is only needed to pick the number
# of decimals automatically; when ``decimals`` is set explicitly we
# avoid touching ``self.axis`` so the formatter also works when it
# is not attached to an axis.
ax_min, ax_max = self.axis.get_view_interval()
display_range = abs(ax_max - ax_min)
else:
display_range = None
return self.fix_minus(self.format_pct(x, display_range))

def format_pct(self, x, display_range):
Expand Down
Loading