Add loongarch64 image comparison tolerances#31940
Conversation
|
Thank you for opening your first PR into Matplotlib! If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks. We also ask that you please finish addressing any review comments on this PR and wait for it to be merged (or closed) before opening a new one, as it can be a valuable learning experience to go through the review process. You can also join us on discourse chat for real-time discussion. For details on testing, writing docs, and our review process, please see the developer guide. We strive to be a welcoming and open project. Please follow our Code of Conduct. |
* Add loongarch64 image comparison tolerances * See also: matplotlib/matplotlib#31940 Signed-off-by: Zhou Qiankang <wszqkzqk@qq.com>
|
Thanks! There are some linting errors. Please run |
Signed-off-by: Zhou Qiankang <wszqkzqk@qq.com>
According to |
|
Ahh, right. I usually rely on pre-commit and had forgotten the details... :-) Looks good! |
PR summary
LoongArch64 Linux produces small rasterization differences compared to the x86_64 baselines, similar to the existing tolerances for macOS and ARM64.
This adds loongarch64 to the platform checks in the 15 image comparison tests that currently fail on LoongArch64.
Each value is reused from the one already used for darwin or aarch64 in the same test.
Verified by running the full matplotlib test suite on real LoongArch64 hardware on Arch Linux for Loong64. (Python 3.14, FreeType 2.13.1)
AI Disclosure
AI was used to help identify the failing tests, analyze the correlation with existing macOS/ARM64 tolerances to reuse the exsting code correctly.
PR checklist