Skip to content

Fix legend settings not preserved when regenerating in Qt dialog #31934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
M-ndak wants to merge 1 commit into
base: main
Choose a base branch
from
+35 −2
Open

Fix legend settings not preserved when regenerating in Qt dialog #31934

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 35 additions & 2 deletions lib/matplotlib/backends/qt_editor/figureoptions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"""Module that provides a GUI-based editor for Matplotlib's figure options."""

from itertools import chain
from matplotlib import cbook, cm, colors as mcolors, markers, image as mimage
from matplotlib import cbook, cm, colors as mcolors, markers, image as mimage, patches as mpatches

Check warning on line 9 in lib/matplotlib/backends/qt_editor/figureoptions.py

View workflow job for this annotation

GitHub Actions / ruff 

[rdjson] reported by reviewdog 🐶
Line too long (98 > 88)

Raw Output:
message:"Line too long (98 > 88)"  location:{path:"/home/runner/work/matplotlib/matplotlib/lib/matplotlib/backends/qt_editor/figureoptions.py"  range:{start:{line:9  column:89}  end:{line:9  column:99}}}  severity:WARNING  source:{name:"ruff"  url:"https://docs.astral.sh/ruff"}  code:{value:"line-too-long"  url:"https://docs.astral.sh/ruff/rules/line-too-long"}
from matplotlib.backends.qt_compat import QtGui
from matplotlib.backends.qt_editor import _formlayout
from matplotlib.dates import DateConverter, num2date
Expand Down Expand Up @@ -248,12 +248,45 @@
if generate_legend:
draggable = None
ncols = 1
shadow = False
fancybox = None
framealpha = None
legend_title = None
bbox_to_anchor = None
loc = 'best'
mode = None
borderaxespad = None

if axes.legend_ is not None:
old_legend = axes.get_legend()
draggable = old_legend._draggable is not None
ncols = old_legend._ncols
new_legend = axes.legend(ncols=ncols)
shadow = old_legend.shadow
fancybox = isinstance(
old_legend.legendPatch.get_boxstyle(),
mpatches.BoxStyle.Round)
framealpha = old_legend.get_frame().get_alpha()
legend_title = old_legend.get_title().get_text() or None
loc = old_legend._loc
mode = old_legend._mode
borderaxespad = old_legend.borderaxespad
# Preserve bbox_to_anchor if it was explicitly set
if not old_legend._loc_used_default:
bbox_to_anchor = old_legend.get_bbox_to_anchor()

new_legend = axes.legend(
ncols=ncols,
shadow=shadow,
fancybox=fancybox,
framealpha=framealpha,
title=legend_title,
loc=loc,
mode=mode,
borderaxespad=borderaxespad,
)
if new_legend:
if bbox_to_anchor is not None:
new_legend.set_bbox_to_anchor(bbox_to_anchor)
new_legend.set_draggable(draggable)

# Redraw
Expand Down
Loading