Sync shared limits without callbacks#31905
Open
samiat4911 wants to merge 2 commits into
Open
Conversation
Author
|
hello @timhoffm would love you to take a look thanks :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
Shared axes now remain synchronized when axis limits are changed with
emit=False.Previously,
Axis._set_lim()usedemitto control both callback emission andshared-axis limit propagation. As a result, calls such as:
updated only the first Axes. The shared Axes retained different limits while
using the same tick locator, which could produce incorrect tick positions.
This change separates shared-axis propagation from callback emission by adding
an internal propagation flag. The initiating call updates every shared Axes,
while propagated updates disable further propagation to prevent infinite
recursion.
emit=Falsecontinues to suppress limit-change callbacks.The existing shared-axis callback test now also verifies that:
emit=False;This follows the design discussion in #26011.
Closes #26085
AI Disclosure
OpenAI Codex was used to implement the fix, add regression coverage, run available validation. The changes were reviewed and validated with local static checks and runtime smoke tests.
PR checklist