fix: allow array-like fill_between where masks#31898
Open
cyphercodes wants to merge 2 commits into
Open
Conversation
timhoffm
approved these changes
Jun 15, 2026
timhoffm
left a comment
Member
There was a problem hiding this comment.
While we loose the bool typing, we certainly want to accept arrays. So widening is reasonable.
Author
|
Updated the generated Verification:
I also inspected the broader failing CI logs. The remaining GitHub/Azure matrix failures I saw are in |
timhoffm
approved these changes
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
Axes.fill_betweenandAxes.fill_betweenxalready accept NumPy boolean masks forwhereat runtime, but their stubs only allowedSequence[bool]. This widens thewhereannotation toArrayLike, matching the rest of the input arrays and avoiding false-positive type checker errors fornp.ndarraymasks.Fixes #31890.
AI assistance was used to prepare this patch.
PR checklist
Testing
PYTHONPATH=lib pyright /tmp/mpl_fill_between_pyright.pypython -m compileall -q lib/matplotlib/axes/_axes.pyigit diff --check