check transform mesh shape in _get_transform_mesh#31894
Open
uwezkhan wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
_get_transform_meshbuilds an input mesh sized to the output image, hands it to the supplied transform'sinverted().transform(), and forwards whatever comes back to the resampler as a flat table ofout_h * out_wcoordinate pairs. The only check on the returned array isndim == 2. A non-affine transform whose inverse returns fewer rows than requested, or a trailing dimension other than 2, leaveslookup_distortionin_image_resample.hindexing past the end of that buffer.Before: an undersized mesh produces an out-of-bounds read during resampling, and with a large output array it segfaults. After: the row and column counts are checked against the requested size and a
RuntimeErroris raised, alongside the existingndimcheck directly above it. The tradeoff is two integer comparisons per non-affine resample; keeping the check next to the mesh construction lets the resampler keep treating the buffer as exactly sized.Minimal repro on the current tree:
AI Disclosure
PR checklist