PERF: Speed up legend best calculations#31803
Open
scottshambaugh wants to merge 2 commits into
Open
Conversation
2d0127a to
8fc13ec
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
Closes #8108
The 10 candidate legend locations are grid aligned, and so share edges. We can speed up the
count_containshot path by computing whether each point lies in those candidate intervals once, rather than looping over each location. In my profiling, I see a ~5x speedup forLegend._find_best_position.Did not deprecate
count_containssince I found some instances of it being used on github, but it's no longer used anywhere internally so could remove. Added a test since it's no longer being exercised otherwise.Before:
After:
Should hopefully cut down a lot on the warning
Creating legend with loc="best" can be slow with large amounts of dataAI Disclosure
Claude code used for first cut, manually cleaned up and refactored.
PR checklist