Fix invalid format string in set_xticklabels error message. - #31758
Merged
Conversation
"=" happens to be a valid format string for numeric values, but not for arbitrary objects, so an error (`TypeError: unsupported format string passed to <objecttype>.__format__`) would previously occur *while formatting the error message* for something like `set_xticklabels(object())`. (The actual case where I saw this happen is when I wrongly passed a Formatter to set_xticklabels.) Also remove a fairly pointless comment.
story645
approved these changes
May 27, 2026
QuLogic
approved these changes
May 27, 2026
timhoffm
added a commit
that referenced
this pull request
May 27, 2026
timhoffm
added a commit
that referenced
this pull request
May 27, 2026
…758-on-v3.11.x Backport PR #31758 on branch v3.11.x (Fix invalid format string in set_xticklabels error message.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"=" happens to be a valid format string for numeric values, but not for arbitrary objects, so an error
(
TypeError: unsupported format string passed to <objecttype>.__format__) would previously occur while formatting the error message for something likeset_xticklabels(object()).(The actual case where I saw this happen is when I wrongly passed a Formatter to set_xticklabels.)
Also remove a fairly pointless comment.
PR summary
AI Disclosure
PR checklist