BUG: Don't try to show / autoscale 3D data that lies outside the axis valid scale range#31737
Open
scottshambaugh wants to merge 2 commits into
Open
BUG: Don't try to show / autoscale 3D data that lies outside the axis valid scale range#31737scottshambaugh wants to merge 2 commits into
scottshambaugh wants to merge 2 commits into
Conversation
08f0bac to
629d396
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
Closes #31726
Marking for 3.11 as the 3D log behavior is new this version, but I'm not actually clear on the inclusion criteria for bugfixes during an rc cycle.
This keeps the current
Scale.val_in_rangebehavior of returning bare True/False for non-iterable inputs, though that was introduced in 3.11 so could change that before it goes out. Not completely necessary to vectorize that function, but it will get called a lot so I expect performance this way to be better.AI Disclosure
Claude did the first pass, I cleaned up it after.
PR checklist