Skip to content

DOC: correct some outdated points in Artist tutorial#31696

Open
rcomer wants to merge 2 commits into
matplotlib:mainfrom
rcomer:artist-tutorial
Open

DOC: correct some outdated points in Artist tutorial#31696
rcomer wants to merge 2 commits into
matplotlib:mainfrom
rcomer:artist-tutorial

Conversation

@rcomer
Copy link
Copy Markdown
Member

@rcomer rcomer commented May 17, 2026

PR summary

  • "As we will discuss below..." does not lead to any discussion of this below. I thought about instead linking to the embedding examples, but these days you don't have to be doing your own clever things with canvases to not use pyplot. We could change a lot of this tutorial to instantiate the figures directly, but there are two examples that use sphinx-gallery to show a plot, and I think they do need pyplot.
  • I think the hold state reference relates to some functionality that was deprecated in v2.
  • Updated the print output to what I currently see.

AI Disclosure

None

PR checklist

@github-actions github-actions Bot added the Documentation: tutorials files in galleries/tutorials label May 17, 2026
@rcomer
Copy link
Copy Markdown
Member Author

rcomer commented May 17, 2026 •
edited
Loading

This tutorial also states

Each of the properties is accessed with an old-fashioned setter or getter (yes we know this irritates Pythonistas and we plan to support direct access via properties or traits but it hasn't been done yet).

Do we still have an aspiration to make properties for the properties? I don't even know what traits are.

timhoffm
timhoffm approved these changes May 17, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@timhoffm timhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plus possibly the suggested change, buy you can decide.

Overall, there's a lot more that can and should be changed in the tutorial, but I don't want to go down this rabbit hole right now.

Comment thread galleries/tutorials/artists.py Outdated
@rcomer @timhoffm
Apply suggestion from @timhoffm
d96a905 
Co-authored-by: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@timhoffm timhoffm timhoffm approved these changes

Assignees

No one assigned

Labels

Documentation: tutorials files in galleries/tutorials

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rcomer @timhoffm