ENH: Add PolarAxes.get_rlim() and get_thetalim() for API symmetry#31695
Open
tinezivic wants to merge 1 commit into
Open
ENH: Add PolarAxes.get_rlim() and get_thetalim() for API symmetry#31695tinezivic wants to merge 1 commit into
tinezivic wants to merge 1 commit into
Conversation
2d28b7f to
384c059
Compare
384c059 to
9d4ca1f
Compare
timhoffm
reviewed
May 17, 2026
Member
timhoffm
left a comment
There was a problem hiding this comment.
Thanks, looks good except for small wording improvements.
Comment on lines
+8
to
+10
| `~matplotlib.projections.polar.PolarAxes.set_thetalim`. Previously, calling | ||
| these getters raised an ``AttributeError``; the workaround was to call the | ||
| base-class ``get_ylim()`` / ``get_xlim()`` directly:: |
Member
There was a problem hiding this comment.
Suggested change
| `~matplotlib.projections.polar.PolarAxes.set_thetalim`. Previously, calling | |
| these getters raised an ``AttributeError``; the workaround was to call the | |
| base-class ``get_ylim()`` / ``get_xlim()`` directly:: | |
| `~matplotlib.projections.polar.PolarAxes.set_thetalim`. Previously, one | |
| had to use `.Axes.get_ylim`, `.Axes.get_xlim` as a workaround. | |
| :: |
Attribute error is implied when a method does not exist and is not worth mentioning.
Since you end with the previous behavior, don't :: at the end of it, because that renders
a : at the end of the sentence, which would falsely imply that the following example is related to the sentence.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
PolarAxes has set_rlim() and set_thetalim() but no corresponding getters.
Added get_rlim() (delegates to get_ylim()) and get_thetalim() (delegates to get_xlim()).
Closes #31694
AI Disclosure
Used GitHub Copilot to understand the existing PolarAxes implementation. The fix and verification are my own.
PR checklist
PR checklist
doc/release/next_whats_new/polar_get_rlim_thetalim.rst