Backport an additional fix to qhull printf strings#31672
Merged
Conversation
Some time after my PR was merged, an additional commit was made to the upstream repository fixing a missed NULL check on an internal error message: qhull/qhull@d1c2fc0 I have backported the patch, dropping the changelog, and reverting all the whitespace changes so that the change is minimal.
Member
Author
|
The source for this backport is QuLogic/qhull@v8.0.2...QuLogic:qhull:fix-format-string-backport |
tacaswell
approved these changes
May 15, 2026
ksunden
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
Some time after my PR was merged, an additional commit was made to the upstream repository fixing a missed NULL check on an internal error message:
qhull/qhull@d1c2fc0
I have backported the patch, dropping the changelog, and reverting all the whitespace changes so that the change is minimal.
AI Disclosure
None
PR checklist