Drop support for Inkscape < 1#31660
Draft
QuLogic wants to merge 2 commits into
Draft
Conversation
It is stuck on 0.91, which is 11 years old.
QuLogic
commented
May 12, 2026
Comment on lines
-174
to
-178
| # Old versions of Inkscape (e.g. 0.48.3.1) seem to sometimes | ||
| # deadlock when stderr is redirected to a pipe, so we redirect it | ||
| # to a temporary file instead. This is not necessary anymore as of | ||
| # Inkscape 0.92.1. | ||
| stderr = TemporaryFile() |
Member
Author
There was a problem hiding this comment.
Hmm, it appears that this comment may be incorrect. It works for me locally with 1.4.3, and on older Ubuntu 22.04 with 1.1.2, but times out with Ubuntu 24.04 that has 1.2.2
This version was released in 2020, which should be sufficiently long enough to have reached development machines.
timhoffm
approved these changes
May 13, 2026
Member
|
appveyor failure looks like a hang halfway through, restarted that job. |
tacaswell
approved these changes
May 13, 2026
Member
Author
|
Hmm, I'll have to test if the AppVeyor hang is a code change, or because of the new Inkscape. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
This version was released in 2020, which should be sufficiently long enough to have reached development machines.
AI Disclosure
None
PR checklist