Drop support for Inkscape < 1 - #31660
Conversation
| # Old versions of Inkscape (e.g. 0.48.3.1) seem to sometimes | ||
| # deadlock when stderr is redirected to a pipe, so we redirect it | ||
| # to a temporary file instead. This is not necessary anymore as of | ||
| # Inkscape 0.92.1. | ||
| stderr = TemporaryFile() |
There was a problem hiding this comment.
Hmm, it appears that this comment may be incorrect. It works for me locally with 1.4.3, and on older Ubuntu 22.04 with 1.1.2, but times out with Ubuntu 24.04 that has 1.2.2
|
appveyor failure looks like a hang halfway through, restarted that job. |
|
Hmm, I'll have to test if the AppVeyor hang is a code change, or because of the new Inkscape. |
|
Comparing the builds logs against a working one, the new Inkscape seems to make tests 10-15% slower up until we get a little under 30% of the way through. Then reaching up to 40%, it's 23% slower, and then it skyrockets to barely reaching 42% tests before AppVeyor kills it. I will try out some older versions. |
|
So even 1.0.2 times out, though it's not nearly as slow. I'll try one more time with the same version we were using before, but from Chocolately and see how that goes for comparison. |
It is stuck on 0.91, which is 11 years old.
This version was released in 2020, which should be sufficiently long enough to have reached development machines.
PR summary
This version was released in 2020, which should be sufficiently long enough to have reached development machines.
AI Disclosure
None
PR checklist