Skip to content

Discourage Lasso widget in docs#31656

Open
whyharshit7 wants to merge 1 commit into
matplotlib:mainfrom
whyharshit7:codex-discourage-lasso-widget
Open

Discourage Lasso widget in docs#31656
whyharshit7 wants to merge 1 commit into
matplotlib:mainfrom
whyharshit7:codex-discourage-lasso-widget

Conversation

@whyharshit7
Copy link
Copy Markdown

Summary

  • mark matplotlib.widgets.Lasso as discouraged in its API docstring and recommend LassoSelector
  • cross-reference the Lasso and LassoSelector gallery examples so users can compare the low-level widget and the preferred selector API
  • add a next API-change note documenting that Lasso is discouraged for new code
  • fix a small typo in the LassoSelector gallery intro

Refs #19221.

Validation

  • python3 -m py_compile lib/matplotlib/widgets.py galleries/examples/event_handling/lasso_demo.py galleries/examples/widgets/lasso_selector_demo_sgskip.py
  • /Users/whyharshit/Documents/Codex/2026-05-11/i-want-you-to-browse-for/bulwark-mcp/.venv/bin/ruff check lib/matplotlib/widgets.py galleries/examples/event_handling/lasso_demo.py galleries/examples/widgets/lasso_selector_demo_sgskip.py
  • git diff --check

I did not run a full docs build locally.

@whyharshit7 whyharshit7 changed the title [codex] Discourage Lasso widget in docs Discourage Lasso widget in docs May 11, 2026
@whyharshit7 whyharshit7 marked this pull request as ready for review May 11, 2026 16:22
@QuLogic
Copy link
Copy Markdown
Member

QuLogic commented May 12, 2026

Please fill out the PR template.

@QuLogic QuLogic added the status: autoclose candidate PRs that are not yet ready for review and may be automatically closed in two weeks label May 12, 2026
@github-actions
Copy link
Copy Markdown

⏰ This pull request might be automatically closed in two weeks from now.

Thank you for your contribution to Matplotlib and for the effort you have put into this PR. This pull request does not yet meet the quality and clarity standards needed for an effective review. Project maintainers have limited time for code reviews, and our goal is to prioritize well-prepared contributions to keep Matplotlib maintainable.

Matplotlib maintainers cannot provide one-to-one guidance on this PR. However, if you ask focused, well-researched questions, a community member may be willing to help. 💬

To increase the chance of a productive review:

As the author, you are responsible for driving this PR, which entails doing necessary background research as well as presenting its context and your thought process. If you are a new contributor, or do not know how to fulfill these requirements, we recommend that you familiarize yourself with Matplotlib's development conventions or engage with the community via our Discourse or one of our meetings before submitting code.

If you substantially improve this PR within two weeks, leave a comment and a team member may remove the status: autoclose candidate label and the PR stays open. Cosmetic changes or incomplete fixes will not be sufficient. Maintainers will assess improvements on their own schedule. Please do not ping (@) maintainers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Documentation: examples files in galleries/examples status: autoclose candidate PRs that are not yet ready for review and may be automatically closed in two weeks topic: widgets/UI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants