MNT: Use new defaults in set_font_settings_for_testing#31484
Open
QuLogic wants to merge 1 commit intomatplotlib:mainfrom
Open
MNT: Use new defaults in set_font_settings_for_testing#31484QuLogic wants to merge 1 commit intomatplotlib:mainfrom
QuLogic wants to merge 1 commit intomatplotlib:mainfrom
Conversation
@tacaswell argued that downstreams will already have to contend with changes in text due to FreeType upgrades, so keeping the old hinting defaults doesn't really help with backwards compatibility and makes things different for other projects for no reason. Followup to matplotlib#30161 (review)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
@tacaswell argued that downstreams will already have to contend with changes in text due to FreeType upgrades, so keeping the old hinting defaults doesn't really help with backwards compatibility and makes things different for other projects for no reason.
Followup to #30161 (review)
AI Disclosure
None
PR checklist