TYP: Add type information to the data parameter of plot functions#31482
Open
timhoffm wants to merge 2 commits intomatplotlib:mainfrom
Open
TYP: Add type information to the data parameter of plot functions#31482timhoffm wants to merge 2 commits intomatplotlib:mainfrom
timhoffm wants to merge 2 commits intomatplotlib:mainfrom
Conversation
Closes matplotlib#31480. We type all as `Mapping[str, Any]`. Some uses have actually a broad range of supported types because they map quite a number of parameters. Even for the ones which we know all parameters supported by `data` are ArrayLike, typing as `Mapping[str, ArrayLike]` may be too risky, as the user may have more keys in the data structure, which we don't use, but their values would be type checked and could be anything.
Member
|
I suspect we are using a different version of black to format the boilerplate output. |
Member
|
See also #25634. |
Member
Author
|
Indeed, this PR does not solve everything. It only removes the complaint on untyped Typechecking of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #31480.
We type all as
Mapping[str, Any]. Some uses have actually a broad range of supported types because they map quite a number of parameters.Even for the ones which we know all parameters supported by
dataare ArrayLike, typing asMapping[str, ArrayLike]may be too risky, as the user may have more keys in the data structure, which we don't use, but their values would be type checked and could be anything.