MAINT: Set "skip internal contributors" to PR welcome bot#31479
Draft
melissawm wants to merge 1 commit intomatplotlib:mainfrom
Draft
MAINT: Set "skip internal contributors" to PR welcome bot#31479melissawm wants to merge 1 commit intomatplotlib:mainfrom
melissawm wants to merge 1 commit intomatplotlib:mainfrom
Conversation
Member
|
The Matplotlib organisation has projects that are maintained independently of Matplotlib itself, so there are org members who have not contributed here yet. I guess that’s a pretty small number though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
This first-contribution github action had a recent new release that breaks our usage. For example:
https://github.com/matplotlib/matplotlib/actions/runs/24148295131?pr=31478
In this case, the action fails with
Error: GH_PAT_READ_ORG env variable is not set.. The new release of the action includes a new option "skip-internal-contributors" that should only require a PAT when set to true, but it is requiring the env var in all cases. This is a bug in first-contributions and I'll report upstream, but in the meantime (and frankly I think this is a good idea regardless) we can set this option to true, as long as we set theGH_PAT_READ_ORG. This means the first-contribution action will not run for all PRs but only for external contributors.AI Disclosure
No AI was used.
PR checklist