Support font features/language in default RendererBase.draw_text#31461
Open
QuLogic wants to merge 2 commits intomatplotlib:text-overhaulfrom
Open
Support font features/language in default RendererBase.draw_text#31461QuLogic wants to merge 2 commits intomatplotlib:text-overhaulfrom
QuLogic wants to merge 2 commits intomatplotlib:text-overhaulfrom
Conversation
If a backend doesn't implement `draw_text`, then we fall back to this implementation that draws paths. It was previously missing support for font features and languages.
This exercises complex shaping, font features, and language support.
882d947 to
4461ad7
Compare
tacaswell
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
If a backend doesn't implement
draw_text, then we fall back to this implementation that draws paths. It was previously missing support for font features and languages.Unfortunately, there is currently no way to test this, as all our internal renderers overridedraw_text, and not using it would produce completely different images due to paths rendering differently than FreeType's images.You can manually test this by renamingRendererAgg.draw_textand then running, e.g.,pytest lib/matplotlib/tests/test_text.py -k 'language or feature'I put together a test that does exactly that using monkey patching to ensure we use the fallback path.
AI Disclosure
None
PR checklist