-
-
Notifications
You must be signed in to change notification settings - Fork 8.3k
DOC: Add thumbnail for ftface_props gallery example #31321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
AMAN194701
wants to merge
8
commits into
matplotlib:main
Choose a base branch
from
AMAN194701:add-ftface-props-thumbnail
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
5f33bb8
DOC: Make ftface_props example generate a font metrics figure
AMAN194701 761fb91
DOC: use TextPath for glyph so size is in data units, matching metric…
AMAN194701 08e2d31
DOC: fix linting errors in ftface_props example
AMAN194701 0d8fe30
STY: fix import order
AMAN194701 e5a1d40
DOC: use Água as sample text to show ascender and descender
AMAN194701 49a542c
DOC: move legend to bottom to avoid label overlap
AMAN194701 6b2ecab
Update galleries/examples/misc/ftface_props.py
AMAN194701 5eb00ba
Use true font.bbox bounds in ftface_props example
AMAN194701 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a clever way to get the lines on the plot without having to adjust the units much, but unfortunately, it's not clever enough.
The
Agtext is positioned in data units, but its size is in points and thus unrelated to theAxesin any way. You can see this immediately by resizing the figure larger vertically; the text stays the same but the ascender and bbox are farther and farther away.You need to rescale things so that they are in the same coordinate space:
Axesas some kind of path, after scaling it so that it's the same units as the metrics (i.e., it should end up in data space just like your metrics),