TST: Cleanup back-compat code in tests touched by text overhaul#31295
Merged
QuLogic merged 1 commit intomatplotlib:text-overhaulfrom Apr 3, 2026
Merged
TST: Cleanup back-compat code in tests touched by text overhaul#31295QuLogic merged 1 commit intomatplotlib:text-overhaulfrom
QuLogic merged 1 commit intomatplotlib:text-overhaulfrom
Conversation
ksunden
approved these changes
Mar 13, 2026
35c1d51 to
4b97b9e
Compare
Member
Author
|
Interesting that some of these ended up with arch-specific failures. |
tacaswell
approved these changes
Apr 2, 2026
tacaswell
approved these changes
Apr 2, 2026
Member
tacaswell
left a comment
There was a problem hiding this comment.
modulo changing the labels in stacked bar to not be confusingly uncorrelated with image.
Member
Author
|
Now with less weird labels: aee9f3a#diff-9b500f5fc75e520c073521c3a4fdabeedc8ae8db0935f7184ac7f128f200cb27 After confirming some CI works, I'll move these images to the other branch and merge this one. |
These tests had previously kept some code or settings to prevent regenerating the test image, but since they are now going to be regenerated from the text overhaul, we can remove those.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
These tests had previously kept some code or settings to prevent regenerating the test image, but since they are now going to be regnerated from the text overhaul, we can remove those.
This includes several merges preemptively; only the last commit is relevant here.
AI Disclosure
None
PR checklist