Log warning during ..plot to sphix logger#30931
Open
Daniel53245 wants to merge 2 commits into
Open
Conversation
Daniel53245
marked this pull request as draft
January 4, 2026 07:52
Daniel53245
marked this pull request as ready for review
January 5, 2026 02:21
tacaswell
force-pushed
the
log-plot-warning-with-sphinx
branch
from
July 18, 2026 03:31
9296ac3 to
bf7a2de
Compare
Member
|
I have rebased this and manually tested that it works. The next step is to copy the test added in https://github.com/matplotlib/matplotlib/pull/31863/changes to also exercise this failure mode. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
closes #15715
As described in #15715, currently the warning in the ..plot is not correctly handled by the sphinx
By modifying file lib/matplotlib/sphinxext/plot_directive.py , I catch any warning generated during the code execution and log it through sphinx logs. When compiling the document, sphinx will fail on warning with the -W flag
PR checklist