Added handling for undetermined home directory - #30454
Merged
Merged
Conversation
QuLogic
approved these changes
Aug 22, 2025
timhoffm
approved these changes
Aug 22, 2025
Member
|
I took the liberty of adding a comment on the cause of the RuntimeError. This is ready to be (suqash-)merged after CI pass. |
Member
|
Thanks @Logan-Pageler! Congratulations on your first PR to Matplotlib 🎉 We hope to hear from you again. |
rokokol
added a commit
to rokokol/matplotlib
that referenced
this pull request
Aug 28, 2026
The warning announcing the fallback to a temporary cache directory lost its f-prefix when the message was refactored in matplotlib#30454, so it prints a literal "{configdir}". Restore the interpolation, and when MPLCONFIGDIR is set explicitly, name the variable instead of blaming "the default path" the user never touched. Strengthen test_tmpconfigdir_warning to assert that the resolved path appears in the warning; the strengthened test fails on the unfixed code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
If the home directory cannot be created/written to, matplotlib defaults to creating a temporary folder for its caching/config. However, previously, if the home directory could not be determined, a RunTimeError was raised. Now, this pr includes code to handle the RunTimeError from
Path.home()so that Matplotlib will default to using a temp directory for its cache. It will also throw a warning to describe the issue.On Windows the following now leads to a temporary cache directory:
On Linux the following now leads to a temporary cache directory, if the user is not a part of the password database:
closes #30449
PR checklist