Thank you for your contribution @saikarna913. Please look through the points in our Summary for Authors and try to address any that seem relevant. In particular you will need to add a test and a type hint. After adding the type hint, you will need to run boilerplate.py so that pyplot.table is updated to match Axes.table.

@rcomer i want to test this code, but I am unable to install the matplotlib completely it is giving me the import error
I’m facing issues installing Matplotlib in the development environment, both on my local desktop and in GitHub Codespaces. It’s throwing an import error, so I’m unable to test the code changes I’ve made.

Here’s what I’ve done so far:

1. Forked the Matplotlib repository.
2. Created a new environment and installed dependencies using:

   pip install -r requirements/dev/dev-requirements.txt

3. also tried GitHub Codespaces by activating the environment with:

   conda activate mpl-dev

4. Installed Matplotlib in editable mode with:

   python -m pip install --verbose --no-build-isolation --editable ".[dev]"

5. Also tried:

   python -m pip install --no-build-isolation --config-settings=editable-verbose=true --editable .

Despite these steps, I’m still encountering the import error. Could you help me figure out why this might be happening?

I just tried running the tests against a clean branch in codespaces. I saw a few failures (#29218) but no ImportError, so I am not sure what to suggest.

@rcomer I have tested the code by using this test code

import matplotlib.pyplot as plt
import numpy as np

# Data for plotting
x = np.linspace(0, 10, 100)
y = x + 1
tableData = [['a', 1], ['b', 1]]

# Create the figure and axis objects
fig, ax = plt.subplots()

# Plot the data
ax.plot(x, y)

# Add a table
t = ax.table(
    cellText=tableData,  # Table content
    loc='top',  # Position of the table
    cellLoc='center',  # Center-align the text in cells
    fontsize=30  # Set the font size for the table
)

# Save the figure as an image
plt.savefig('output_plot_with_table_after.png')  # Save as PNG file

# Optionally, close the plot (no need to display it)
plt.close()

I got this output

As a beginner, I’m not fully sure about type hints. Could you guide me on where exactly to add them in my code? I also attempted to include the following test code:

import pytest
import matplotlib.pyplot as plt
import numpy as np

# Test function for fontsize in table
def test_table_fontsize():
    # Data for plotting
    tableData = [['a', 1], ['b', 1]]
    
    # Create the figure and axis objects
    fig, ax = plt.subplots()
    
    # Plot the data (although we are focusing on the table)
    ax.plot(np.linspace(0, 10, 100), np.linspace(0, 10, 100) + 1)
    
    # Add a table with fontsize=30
    t = ax.table(
        cellText=tableData, 
        loc='top', 
        cellLoc='center', 
        fontsize=30
    )
    
    # Retrieve the font size from a specific cell (e.g., cell (0, 0))
    cell_fontsize = t[(0, 0)].get_fontsize()
    
    # Assert that the fontsize is correctly set to 30
    assert cell_fontsize == 30, f"Expected fontsize 30, but got {cell_fontsize}"

    # Clean up by closing the plot (important for pytest to avoid hanging processes)
    plt.close()

This test code has been running for a long time. I don't know why.

The type hint goes in table.pyi. Hopefully when you compare what's already in there with table.py it should be fairly intuitive what needs adding.

@rcomer , please review this PR and approve it

• added the type hint and ran the boilerplate
• tested the code with a new test case added in test_table.py

Thank you, @saikarna913.
This may sound annoying, but can you correct the flake8 formatting issues? If you work in VS Code, there are extensions to highlight flake8 issues.

@NGWi removed the flake issues
can you approve this pr

@saikarna913 it looks like you have run an auto-formatter such as black. This makes the size of the change much larger than is necessary for the PR. I’m sorry but you will need to revert those changes. Note that Matplotlib intentionally does not use black.

@rcomer done. please let me know if any changes required

@saikarna913 please take a look at the automated tests below. Mypy has failed although it was passing before. Mypy checks the type hints so something has gone wrong there.

Actually the Mypy failure is something to do with pylab, which you have not changed. So I don't actually know what is going on there 😕

@saikarna913 did you mean to close this?

I believe this has been replaced by #29258.

I believe this has been replaced by #29258.

yes, can you review my changes