Skip to content

Use both TCL_SETVAR and TCL_SETVAR2 for tcl 9 support#29144

Merged
jklymak merged 2 commits into
matplotlib:mainfrom
ksunden:tcl9
Nov 15, 2024
Merged

Use both TCL_SETVAR and TCL_SETVAR2 for tcl 9 support#29144
jklymak merged 2 commits into
matplotlib:mainfrom
ksunden:tcl9

Conversation

@ksunden
Copy link
Copy Markdown
Member

@ksunden ksunden commented Nov 15, 2024

Provides both the older and newer APIs for compatibility with both tcl 9 plus and older versions.

Co-authored-by: Antony Lee anntzer.lee@gmail.com

Closes #29126

PR summary

PR checklist

Co-authored-by: Antony Lee <anntzer.lee@gmail.com>
Comment thread src/_tkagg.cpp Outdated
@tacaswell tacaswell added this to the v3.10.0 milestone Nov 15, 2024
@tacaswell
Copy link
Copy Markdown
Member

As this is a patch from @anntzer added by @ksunden and reviewed by me I think this has enough review and can be merged by anyone on green.

@jklymak jklymak merged commit 183b04f into matplotlib:main Nov 15, 2024
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Nov 15, 2024
QuLogic added a commit that referenced this pull request Nov 16, 2024
…144-on-v3.10.x

Backport PR #29144 on branch v3.10.x (Use both TCL_SETVAR and TCL_SETVAR2 for tcl 9 support)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: TkAgg backend is broken with tcl/tk 9.0

3 participants