DOC: plotting section for Users Guide#29124
Conversation
|
Given that this is clearly a lot of work, what's the motivation for this section/this new set of docs? What problem/questions from folks are you seeing that you're trying to solve here that's not currently being addressed in the gallery? |
235b82e to
4856e0d
Compare
4856e0d to
2a0455e
Compare
|
I'll ping for a review for this. Obviously this can just be considered scaffolding. I believe I addressed why the gallery is not a replacement for explaining how to make plots in the User Guide in the PR description. The gallery will never be a cohesive introductory guide, and I think that is fine. The approach here is to provide a basic start with links to more examples in the appropriate section of the gallery, or elsewhere in the User Guide. |
There was a problem hiding this comment.
Not having the time for a thorough review right now. I'll give a very brief feedback so that this does not stand uncommented.
I understand and agree with the fundamental idea. I'm slightly annoyed by the structural duplication of this page and "Plot types".
Way of working: This is a massive PR, which makes reviewing hard. I would have to reserve a significant time slot to look into it, which raises the bar and lowers the motivation. Additionally, the whole thing came without prior heads/up discussion. This means I first have to review overall approach and structure plus all the content intermixed and at the same time. I'm feeling overwhelmed by this. Also, I'm afraid of looking into/starting a discussion on the structure, because that may involve a lot of follow-up work due to all the details already written out.
Overall, this was the motivation for me to not look into a review.
IMHO this would work better if
- you first create an issue describing the topic, and the idea for the stuctural solution (optionally/alternatively make a proof-of-concept PR for the structure). We could then agree on a the structure first.
- then make a PR that puts the desired structure in place
- after that, add multiple PRs for the individual sections.
This would keep the PRs smaller and more focused and significantly ease reviewing.
This was deliberately done so that they would present material in the same order but with more depth than in the quick visual index of "Plot Types". I'm not sure I understand the annoyance - particularly given that I made the Plot Types PR.
I'd consider this the proof of concept PR. If you have serious objections to the structure, folks could propose alternates. If not, I'd suggest this PR is better than nothing, which is what we currently have. If folks disagree and feel it is worse than nothing, then we should close the PR and continue to have a large gap in the docs. |
I'm not sure what gap it is you're trying to fill with these docs. The plot type gallery is already heavily curated, so I don't think that the narrative is adding much here. Some of the examples feel so bogged down with extras that I'm not sure that readers will pick up the pattern that I think is what you're trying to convey, and information on how to use each specific function. I think if there's a gap here, it's in understanding the artists that back the plots and I'd orient the user guide plotting section around those underlying artists. |
|
The User guide has how to make a figure, how to make an axes, ...., a bunch of complicated stuff. I don't think "go look at the plot types gallery" is a good substitute for that middle ground, and I don't think the plot types gallery ties visualizations together in a hierarchy other than their ordering. Which is great - I look at the plot type gallery as a quick overview of what the library can do that a user can quickly scan to see if their chosen visualization is there, and see what we call it. This new section of the User Guide should get into more details and connect the visualizations which is what I tried to start here. For sure, adding more detail about the underlying artists could be helpful, though I'd perhaps not ruin the flow so much as show a few examples of using the artists, and link out to the API docs or explanation elsewhere in the the Guide.
I'm not sure what you are referring to here, but the examples are meant to be semi complete visualizations in most cases. If folks feel something got too far into the weeds, they are welcome to propose scaling a section back or breaking it into components. I do somewhat feel you are expressing two contradictory ideas of what this section is meant for; "more details about underlying artists" and "fewer extras" are pulling in opposite directions. Obviously writing examples is a balancing act, and folks should feel free to edit this first pass all they want. |
That's because the user guide introduces the concept of a figure, axes, colormap, etc, all of which are backed by objects. There's not a concept of a plot in the same manner, the closest being the artists that underlie the plot. And it covers the basics of how to make a plot in getting started and in the discussions of the library components relevant for that plot.
For example, this gets so bogged down in the user warning (which is better explained in the API docs) that it loses focus on how to use the function (if that's the goal) For example, the focus here is on setting up the data, the actual usage of the function not changing from the usage above: matplotlib/galleries/users_explain/plotting/gridded.py Lines 121 to 133 in 2a0455e For example, the goal of this example is presumably to contrast the two, which a reader can pick up from the gallery thumbnails:
What I mean by focusing on the artist is more documents in the style of https://matplotlib.org/devdocs/users/explain/artists/imshow_extent.html. It unpacks a characteristic of ImageBase objects that once the reader understands it, they can then apply that understanding to every plotting method that takes an extent keyword. |
From my point of view people need to be able to make a figure, make and axes, and then make visualizations in those figures and axes. The User Guide as it stands does not have that last step. They are all underscored by objects, so I'm not following what that has to do with explaining how to use the library.
I'd say both of these are somewhat asides that help the user better use the library. You could easily argue that the asides should be in a separate page or put in-line. But I don't think a deep-dive on every artist type and its quirks is the right level for the top-section of the user guide. From my point of view, if it can be explained quickly, inline is OK, if not then it should be linked out to a dedicated subpage. |
|
I give one high-level comment, other than that I'm out of the details here, because the PR gives me a mental overload: I definitively see a place for a more detailed usage description of (some) plotting functions.
The user guide is certianly the right place for this. (How to plot with lines / markers / images). I'm not clear though on the framing / perspective. I'm feeling that the focus on "plotting methods" (Document: Using matplotlib > Plotting methods, and using method names as the sections) is wrong for a user guide. I think it should instead be something like "Using matplotlib > Visualizing different kinds of data". Then the subsections "pairwise data", "statistical plots", ... in here are ok. But within these sections again, it should not be methods but "drawing lines, markers, bars, ..." etc. |
Because those sections are focused on explaining what a figure (object) is and how to create it, what an axes (object) is and how to create it, etc. @timhoffm is also suggesting by artist here, just implicitly:
Because each of those visual elements is backed by a different artist. |
To be precise, I'm suggesting by kind of visualization. There's a strong parallel between "kind of visualization" and Artists, but it's not exactly 1:1 (lines = Line2D, markers = Line2D). And my point is that the user guide should be written from the perspective what the user wants (e.g. a color-coded visualization of 2D data) not what we provide (a method |
Sure agreed. That is basically what the current version does. It explains the type of data to be visualized and then explains the different methods to accomplish that. We don't want these to be completely abstract. Users should learn out names for things. And they should also learn the differences between the methods. |
I think you are making a distinction here that the original author of those sections didn't intend. However, the practical difference between an Axes object and a Line2d object is that you need to call many methods on the Axes object to use the library at all (or use pyplot). On the other hand, you could make hundreds of complicated visualizations using Line2d artists and not know any of the methods on that artist, or that the artist object even exists. Not at all to argue that these sections should avoid mentioning or using artists, just that I don't think that should be a focus at the top level. |
But what @timhoffm (and I agree) is saying is it should be grouped by visualization task. I think some of this is fixable with subheadings saying things like "Plotting lines", etc... I think what's getting jumbled up here is that method and task aren't a 1:1 either. Like scatter plots can be made using .plot or .scatter, line plots can be made using .plot, and for special types of lines .vlines, .hlines, .axline, .event and |
The current headings are:
The sections start with a short intro about the type of data to be visualized, and then are indeed subsectioned by method type. So taking "Pairwise data" , it has
we could maybe expand the description of things you do with pairwise data a bit at the beginning, but this is pretty obvious thing to do with your data. We could also change the headings, but to what without being too verbose? "plot" -> "plotting lines and markers, one color and marker at a time" "fill_between"-> "indicating regions around a line"? The first sentence of each of these sections basically says what the primary goal of the method is, so in my opinion it's clearest just to use the method name. New users may not know our names for things, but the hope is they can realize they want to plot pairwise data, and then skim the plots for the method most suited to their visualization and then read more. |
1882990 to
9b56ba2
Compare
|
https://diataxis.fr/explanation/ has a lot more detail than the table. A key line from that page
This is a coherent prose document that if we pointed someone with a reasonable scientific training at they could read start-to-finish, never go run a line of code, and come out with a solid basis to start using Matplotlib effectively. This is exactly the docs I wish I could point many of the people I support at my day-job at. While it is true that this do not go into the history of every design decision, it does help the user decide which of several similar looking tools (imshow, pcolor, pcolormesh, ...) to reach for or provide some justification of why the kwrag on I think the "Why...?" this is answering is "why does this even exist? What unique visualization problem is it solving that is not already solved by some other function?" I am very much against any proposal to cut this down, the core value is the complete narrative. Again quoting diataxis:
To the organization concern, I think that this is the right skeleton to start reorganizing every other document in |
That is the goal - once the basic outline is there, I think it's relatively straight forward to iterate and make things more cohesive. |
|
I do have concerns on structure, content, style and quality. As originally said, I feel unable to properly review and address them due to the size of the PR. Therefore I'll recurse myself from this discussion and let others decide how to proceed. My only request would be that you add a documentation section next to https://matplotlib.org/devdocs/devel/document.html#examples-guidelines and https://matplotlib.org/devdocs/devel/document.html#plot-types-guidelines that describes intent and recommendations of this new part of the docs. Otherwise I'm afraid everybody will have their own mental model how this should look like and future iterations will not converge to a consistent or desired state. |
That's basically how open source works.
My concern is the size of this PR will make it really difficult/overwhelming to go in and make changes, so effectively we're stuck with it. I don't think this hole is so urgent to fix that we need to rush a solution.
They could do that from the quickstart guide. There's really nothing extra here from a conceptual standpoint that they can't find in our API docs or examples.
Can you find someone and point them at this PR and see if it works for them? Built pages B/c frankly the more times I read this PR, the more I see small details that in my experience would derail a learner. ETA: what I mean is there are a lot of descriptive notes - use this aspect ratio, the function does this - but it's missing the why the reader needs to know this/why is the tutorial telling the reader this.
Almost all that "why" is already in the plot gallery preamble. I think the user guide should explain what the user needs to know about why Matplotlib solves this visualization problem this way so that they can use the functions effectively.
Who is doing that work w/o consensus/buy-in that this is what we want?
I don't follow what you mean here and therefore am not sure how this makes any sense for the structural artist docs (figure/axes/etc) which are currently discoverable. Which currently the implicit organizing principle of the user guide is the "anatomy of Matplotlib" figure, which I think makes sense if the goal is learning Matplotlib concepts. |
I think that should be a separate PR that comes first b/c that discussion would get to the consensus that I think this PR needs. |
Sure, done. I added a section on tutorials as well since that was missing, and updated the table to have a bit of info about the goal of each section of the galleries, made that a subsection, and added a link near the table to the subsection. Note this is a separate commit: 2bb91bb |
55485af to
2f70bc2
Compare
|
On a side note, I believe our "User Guide" is both "Explanation" (e.g. Introduction to Artists) and "How-to" (e.g. Faster Rendering Using Blitting). That may or may not be good, but is out of scope for this PR. The important part is that we agree on which category "Plotting data" is. I agree with @jklymak (#29124 (comment)) that "Plotting data" is a "How-to". Essentially,
I like the tutorials section. 👍 I'm unclear on the user guide section, which also stems from the fact that the user guide is currently "How-to" and "Explanation". I would not bother on trying to define this now and here. Just the "plotting data" section should be enough. |
Sorry to cross talk in #31496... As I state there, I think it's awkward to discuss a subsection of the User Guide like it is standalone. The point of this PR is that it is a gap in the current User Guide. |
The plot type gallery solves one, the links out into the API docs which point to the minigallery that goes to the examples solves two. So what's the value add here? ETA2; What I mean is, what makes this different enough from the minigallery->examples pathway that it's worth maintaining a whole set of docs rather than signposting that pathway better? (We can always add a "what's next? learn to plot through the example gallery" card) ETA: in particular I'm thinking of examples like pie. |
| - Source location | ||
| - Build location |
There was a problem hiding this comment.
can these be one column/ two lines?
There was a problem hiding this comment.
I didn't take this suggestion..
| * - ``examples`` | ||
| - :file:`galleries/examples` | ||
| - :file:`doc/gallery` | ||
| - Visual examples that demonstrate features and common (and uncommon) usage patterns. |
There was a problem hiding this comment.
| - Visual examples that demonstrate features and common (and uncommon) usage patterns. | |
| Demonstrations of library features and usage patterns |
examples is given from the name, not all are visual, and common+uncommon means all
| See :ref:`organization-of-examples-and-tutorials` for more information about how to | ||
| choose what content goes in which gallery. |
There was a problem hiding this comment.
I don't like the word choose here b/c these should be well defined enough that it's clear where the docs go. Like we know if something goes into API b/c it's API docs.
| Outside of the API reference documentation, the Matplotlib documentation consists of | ||
| a collection of examples and tutorials. |
There was a problem hiding this comment.
| Outside of the API reference documentation, the Matplotlib documentation consists of | |
| a collection of examples and tutorials. | |
| the Matplotlib usage documentation consists of the following narrative documentation: user guide, tutorials, and examples. | |
disappearing user guide here does not convey that it's its own thing and not examples/tutorials.
|
|
||
| Plot types guidelines | ||
| --------------------- | ||
| Tutorials are step-by-step guides for learning broader workflows in more depth. |
There was a problem hiding this comment.
can you define broader workflows b/c I'm struggling w/ how artist tutorial is a broader workflow. Granted, I also think it should be folded into the user guide entry on artists.
There was a problem hiding this comment.
These are general guidelines, not meant to cover everything that already exists or be overly binding.
| They should contain explanation and instruction, and can be more cross-cutting | ||
| than individual sections of the user's guide and more in-depth than an | ||
| example. Tutorials need not be limited to assuming basic Matplotlib knowledge, |
There was a problem hiding this comment.
what's the criteria for more cross-cutting and more in depth?
| material into stages with clear subsections, and make it easy for readers to see | ||
| what each section adds and when to refer to other documentation for deeper | ||
| detail on a specific feature. A table of contents may be helpful for longer | ||
| tutorials. |
There was a problem hiding this comment.
suggestion but the thumbnail?header image should usually be the finished product as that'll give folks the "why do I want to read this?"
There was a problem hiding this comment.
The purpose here is not to tell people how to write these. Thumbnails are covered above.
There was a problem hiding this comment.
The rest of this paragraph is content suggestions: sections/headings/toc. This is just another content suggestion.
| the examples. Deep dives into one feature set should usually live elsewhere and | ||
| be linked as further reading when appropriate. |
| be read linearly and build on previously introduced concepts. It should | ||
| contain more explanation and instruction than the gallery of examples, while | ||
| still being concise and to the point. Cross-link related documentation |
There was a problem hiding this comment.
I think that's the sticking point - the difference between user guide and example shouldn't just be that user guide is longer.
There was a problem hiding this comment.
"...just be that the user guide is longer" is not what these sentences are meant to convey.
There was a problem hiding this comment.
That's what "more than" conveys.
There was a problem hiding this comment.
Again, I think the full three paragraphs conveys a lot more than that. If that is all you got out of it, edit suggestions, or comments about what you didn't understand are welcome to make the point clearer.
There was a problem hiding this comment.
What I'm not understanding is if structurally/modally there's supposed to be anything different about a user guide page vs. a tutorial or user guide page vs. an example.
Like "Customizing Plots" could be a tutorial or a user guide entry or a gallery example. We have it in all three flavors - current rc guide, lifestyle of a plot has a lot of styling guidance, examples w/ a styling:type tag. So what distinguishes it as a user guide entry if it's not just "more explanation"? minimal/focused code is the same guidance as for examples.
There was a problem hiding this comment.
- The User Guide should be intentionally organized and largely readable in sequence, at least within each section and ideally across the full guide.
- Tutorials should teach end-to-end visualization workflows, not isolated feature explainers, and should stand alone for readers who have completed the User Guide.
- Examples should be quick visual references: easy to scan, easy to copy, and easy to adapt.
Overlap is expected. But instead of asking “Where does page X belong?”, we should ask, “What does the User Guide need in order to be reasonably comprehensive?”
| describes the content of the page. The code examples should be minimal and | ||
| focused on the concept being explained. Avoid including extraneous code that | ||
| does not directly contribute to the explanation. |
There was a problem hiding this comment.
Honestly, to me some of the examples in this PR don't follow these guidelines. Which I agree w/ in theory, which makes me wonder if we have different definitions of "concept being explained" and "extraneous".
What I'm thinking of in particular is what I see in the comments as digressions on implementation details (aspect, aliasing, color cycles). And also (as I think Tim also mentioned) most of the focus in the preamble of these functions is on the data - I'm feeling like the plotting concept is getting completely lost here.
There was a problem hiding this comment.
Matplotlib is a scientific data visualization tool. Usually scientists have data they want to plot, so I think discussing the data types (pairwise, gridded, etc) and various way to represent that data is a relatively useful way to contextualize. It is also exactly how Plot Types is organized. I'm not sure what "plotting concept(s)" are bing lost.
As for digressions, there may indeed be some. It will be a question whether we should add more, or reduce them, but I expect the former. The ones included were ones I felt were important.
There was a problem hiding this comment.
The ones included were ones I felt were important.
I think if they're important enough to be mentioned, then they should get a proper subsection/paragraph heading w/ explaination on why you're telling them this. Otherwise it feels like a distraction from whatever they're supposed to be learning in the specific example. Mostly cause someone reading the plotting section of the user guide is likely missing all the context for why this is important to know.
There was a problem hiding this comment.
It is also exactly how Plot Types is organized.
B/c plot types is answering the "what chart types can I choose from?" question, while I think user guide is supposed to answer "what can I do w/ the chart type I chose?
I'm not sure what "plotting concept(s)" are bing lost.
For example, the start of the gridded data section is a paragraph and a half on gridded data. There isn't even a brief introduction to the plotting methods, something like "the regular gridded data plotting methods all plot variants of a heatmap, which is a visualization where the data values
Some of this is addressed on the specific methods, but like we both know that it's the
so that should be top level. Especially since it applies to all the gridded methods. It's definitely not less important than aspect, which somehow gets more emphasis - which also you introduce vmin/vmax before norm but vmin/vmax is just implicit norm.
And the reason for telling users what a heatmap is even though we expect they know is to ensure we're using the same terms.
There was a problem hiding this comment.
Sure, first sentence fixed, but note this section is not just about colormapping as contours need not be colored.
As for mapping using norms, a full explanation is linked, and maybe more could be explained here. However, I consider that somewhat intermediate, and I bet 95% of our users never create a norm directly.
There was a problem hiding this comment.
but note this section is not just about colormapping as contours need not be colored
That's why I (and I think Tim) were pushing for some/sub organization under viz type. Group heatmap like functions together so all the shared concepts (colormaps, norms) can be discussed under that header and then the function how tos can be streamlined to the function specific differences. Main reason plot types gallery doesn't have that sub organization is b/c we don't go into that level of detail there. Bonus is easier to edit when we add explainations about colorizer later.
However, I consider that somewhat intermediate, and I bet 95% of our users never create a norm directly.
I've probably been using Matplotlib almost 20 years and I don't think I've ever really cared about the aspect but you think it's very important for understanding how to use imshow. Which fine, I think norm is one of those things that's really important to understand even if you don't make one directly b/c it underpins all the colormapping (at least currently).
Examples are rather anecdotal. They teach by demonstration, rather than by explanation or instruction. Because the visualization and preview image have a strong weight, I'd consider it rather an anti-pattern for examples to have many plots. In that sense, some of the examples, including pie are actually very much the type of content, I'd like to see under "Plotting data" and should be moved there. (they are currently in the examples category because we don't have a dedicated place for them). Another example of "Plotting data" content: |
Agree, argued something similar in #27459 or the discussions around it, (which honestly my motivation there is the same as one of my concerns here - focus is too much on what's being plotted, not enough on how to plot it) and discussions around it. But that's also a very different approach from the one taken in this PR. I'm also deeply skeptical of the "well then rework on next PR to that style" b/c it will run headlong into the same issues as #27459 |
Yes, that'd be great - not including I'd indeed go through the Examples and do some pruning - some of the material is already cribbed from examples, and probably more could be done. |
|
As a side note/feedback: I wasn't able to easily see whether #29124 (comment) and the subsequent force-push did change pie or whether that was just a communication of intent. This unerpins my point that the PR is too large in scope and content to be reviewable. While I rejoined the conceptual high-level discussion, I still won't systematically look at the actual content of the PR. |
|
No pie is not included. As I'm sure many other things are not either. |
|
A bit of backstory. The documentation has had some long-recognized structural challenges:
Addressing this required clearing a few technical hurdles:
With those pieces in place, we could restructure the User Guide as a sphinx-gallery and move substantial tutorial material into it (#25395), while also adding new content to fill gaps. Alongside technical constraints, there was also a process challenge: many good ideas were discussed over time (summits, surveys, working groups, sprints, outside expertise), but progress remained slow. Those approaches can still be valuable, but for this specific problem it also seemed important to make practical, iterative improvements in parallel. My view is that this work was less about finding a perfect information architecture up front and more about putting a clear starting structure in place, then improving it through feedback. Once that structure exists, feedback tends to become more specific and actionable. From that perspective, I believe #29124 is a constructive step forward, even if it is not final. If the project prefers a different direction, it can choose that. Either way, I hope this helps move the docs discussion from general complaints to concrete improvements. |
Most of the discussion here and in #31496 is about getting consensus on structure and content guidelines, so I don't think anyone disagrees on the problems. The reason for the discussion is I think:
A major reason the user guide doesn't get touched is it feels like there really isn't space to make new changes - nobody knows what "improving" looks like. Which that's an underlying goal here, to get some clear consensus on what "improving" means b/c we can translate that into guidance and actionable tasks. ETA: otherwise I think we're mostly just kicking this discussion down the road 'til the next time someone who feels empowered to make these changes makes them, and our goal should be to empower any contributor to make them. |

This PR adds a "plotting" section to the Users Guide. See https://output.circle-artifacts.com/output/job/78379cd7-923b-4f4e-90ed-e297cace49c9/artifacts/0/doc/build/html/users/index.html (update 20 April) It is unusual to have a Users Guide that does not at least cover the basic ways to make visualizations.
The organization is the same as the Plot Types gallery, with the exception that I moved
errorbarout ofstatisticstopairwise; everything else in "statistics" calculates statistics, errorbar, likefill_between/xjust plots an idea of the errors given calculated errors.This allows related visualization types to be shown in a curated order, with narrative connection between the topics. Currently it is pretty high level, and then details referred to the Gallery Examples as either links or in
.. seealso::callouts. Some more details could be covered in each of these sections over time.I've not made any changes outside of these documents, except I added soft references so gallery items can be referenced by
:ref:instead of:doc:. Probably the Gallery Examples could/should link back to the plotting sections. Possibly some gallery sections would want to be removed, but overall I think overlap between the presentations methods is fine.In terms of adding/moving material the balance between whether information belongs in the Example or this section will require some back and forth. Overall I'd recommend erring on the side of redundancy, and using liberal cross linking.