Skip to content

added typing_extensions.Self to _AxesBase.twinx #28625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ksunden merged 5 commits into from
Aug 1, 2024
Merged

added typing_extensions.Self to _AxesBase.twinx #28625

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7aefeba
added typing_extensions.Self to _AxesBase.twinx
randolf-scholz Jul 29, 2024
58e16b1
removed dependency
randolf-scholz Jul 30, 2024
a39580e
Merge branch 'main' into axesbase_twinx_type_hint
randolf-scholz Jul 30, 2024
182f468
Merge branch 'main' into axesbase_twinx_type_hint
randolf-scholz Aug 1, 2024
cf441b9
use Axes instead of Self
randolf-scholz Aug 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions environment.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ dependencies:
- python-dateutil>=2.1
- setuptools_scm
- wxpython
- typing-extensions>=4.0.0
Comment thread
randolf-scholz marked this conversation as resolved.
Outdated
# building documentation
- colorspacious
- graphviz
Expand Down
5 changes: 3 additions & 2 deletions lib/matplotlib/axes/_base.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ from cycler import Cycler
import numpy as np
from numpy.typing import ArrayLike
from typing import Any, Literal, TypeVar, overload
from typing_extensions import Self
from matplotlib.typing import ColorType

_T = TypeVar("_T", bound=Artist)
Expand Down Expand Up @@ -384,8 +385,8 @@ class _AxesBase(martist.Artist):
bbox_extra_artists: Sequence[Artist] | None = ...,
for_layout_only: bool = ...
) -> Bbox | None: ...
def twinx(self) -> _AxesBase: ...
def twiny(self) -> _AxesBase: ...
def twinx(self) -> Self: ...
def twiny(self) -> Self: ...
def get_shared_x_axes(self) -> cbook.GrouperView: ...
def get_shared_y_axes(self) -> cbook.GrouperView: ...
def label_outer(self, remove_inner_ticks: bool = ...) -> None: ...
Expand Down
1 change: 1 addition & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ dependencies = [
"pillow >= 8",
"pyparsing >= 2.3.1",
"python-dateutil >= 2.7",
"typing-extensions >= 4.0.0",
Comment thread
randolf-scholz marked this conversation as resolved.
Outdated
]
requires-python = ">=3.10"

Expand Down